sc-66351 auto onboard large runenrs #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame matches a certain format
…yLaneAI/pennylane-lightning into sc-66351-auto-onboard-large-runenrs
…yLaneAI/pennylane-lightning into sc-66351-auto-onboard-large-runenrs
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #774 +/- ##
===========================================
- Coverage 92.73% 58.71% -34.02%
===========================================
Files 92 17 -75
Lines 13777 1904 -11873
===========================================
- Hits 12776 1118 -11658
+ Misses 1001 786 -215 ☔ View full report in Codecov by Sentry. |
AmintorDusko
approved these changes
Jun 21, 2024
Fix issue with regex check and added additional echo statements to show progress
maliasadi
reviewed
Jun 21, 2024
There was a problem hiding this comment.
LGTM! Don't forget to update the changelog:
* Release candidate branches are automatically switched over to using the new large GitHub runner pool.
[(#769)](https://github.com/PennyLaneAI/pennylane-lightning/pull/769)
[(#774)](https://github.com/PennyLaneAI/pennylane-lightning/pull/774)Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
rashidnhm
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Jun 21, 2024
…ame matches the rc branching format (#846) **Context:** This PR introduces a change to the CI, where a PR that matches the naming format of the RC branches (eg: `vX.Y.Z-rcN`) is automatically on-boarded to use large runner queue *without the usage of a label* **Description of the Change:** This change has been introduced within pennylane-lightning with the following two PRs: - PennyLaneAI/pennylane-lightning#769 - PennyLaneAI/pennylane-lightning#774 **Benefits:** Lower wait times for rc branch builds **Possible Drawbacks:** As noted in the lightning PRs, though the runners have parity, it is possible for a workflow to fail on the larger runners. The `urgent` label will be added to this PR to ensure jobs pass. **Related GitHub Issues:**
albi3ro
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Oct 18, 2024
**Context:**
Currently the CI gets congested when large amounts of pull requests are
being updated simultaneously. This pull request gives PRs an escape
hatch and use large runners and use different queue to have CI jobs be
picked up.
**Description of the Change:**
This pull request adds two new features:
- Ability to add the `urgent` label to any pull request and switch it
over to large runners
- Automatic swap of rc branch to large runner
- This assumes the rc branch is of the format `vX.Y.Z-rcN`
Large runners, albeit slightly more powerful than standard runners, can
be spawned at a much higher volume than standard runners ... this is
because we pay per minute for these runners vs being included on our
GitHub Plan.
If a PR needs CI run without waiting for a runner, **add the `urgent`
label to the pull request**.
Important Note:
- This only affect jobs that run on `pull_request` and use `ubuntu`
runners.
- This change is already in-place in lightning and catalyst.
- PennyLaneAI/pennylane-lightning#774
- PennyLaneAI/catalyst#846
**Benefits:**
Ability to leverage large runner to have quick time for a runner to pick
up a job.
**Possible Drawbacks:**
Though we dictate the pool size of large runners, it is possible to
still saturate it.
**Related GitHub Issues:**
None.
[sc-73711](https://app.shortcut.com/xanaduai/story/73711/update-pennylane-ci-to-use-large-runner-group)
---------
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
austingmhuang
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Oct 23, 2024
**Context:**
Currently the CI gets congested when large amounts of pull requests are
being updated simultaneously. This pull request gives PRs an escape
hatch and use large runners and use different queue to have CI jobs be
picked up.
**Description of the Change:**
This pull request adds two new features:
- Ability to add the `urgent` label to any pull request and switch it
over to large runners
- Automatic swap of rc branch to large runner
- This assumes the rc branch is of the format `vX.Y.Z-rcN`
Large runners, albeit slightly more powerful than standard runners, can
be spawned at a much higher volume than standard runners ... this is
because we pay per minute for these runners vs being included on our
GitHub Plan.
If a PR needs CI run without waiting for a runner, **add the `urgent`
label to the pull request**.
Important Note:
- This only affect jobs that run on `pull_request` and use `ubuntu`
runners.
- This change is already in-place in lightning and catalyst.
- PennyLaneAI/pennylane-lightning#774
- PennyLaneAI/catalyst#846
**Benefits:**
Ability to leverage large runner to have quick time for a runner to pick
up a job.
**Possible Drawbacks:**
Though we dictate the pool size of large runners, it is possible to
still saturate it.
**Related GitHub Issues:**
None.
[sc-73711](https://app.shortcut.com/xanaduai/story/73711/update-pennylane-ci-to-use-large-runner-group)
---------
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
added a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Nov 11, 2024
**Context:**
Currently the CI gets congested when large amounts of pull requests are
being updated simultaneously. This pull request gives PRs an escape
hatch and use large runners and use different queue to have CI jobs be
picked up.
**Description of the Change:**
This pull request adds two new features:
- Ability to add the `urgent` label to any pull request and switch it
over to large runners
- Automatic swap of rc branch to large runner
- This assumes the rc branch is of the format `vX.Y.Z-rcN`
Large runners, albeit slightly more powerful than standard runners, can
be spawned at a much higher volume than standard runners ... this is
because we pay per minute for these runners vs being included on our
GitHub Plan.
If a PR needs CI run without waiting for a runner, **add the `urgent`
label to the pull request**.
Important Note:
- This only affect jobs that run on `pull_request` and use `ubuntu`
runners.
- This change is already in-place in lightning and catalyst.
- PennyLaneAI/pennylane-lightning#774
- PennyLaneAI/catalyst#846
**Benefits:**
Ability to leverage large runner to have quick time for a runner to pick
up a job.
**Possible Drawbacks:**
Though we dictate the pool size of large runners, it is possible to
still saturate it.
**Related GitHub Issues:**
None.
[sc-73711](https://app.shortcut.com/xanaduai/story/73711/update-pennylane-ci-to-use-large-runner-group)
---------
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR fixes an issue introduced as part of the previous pr #769 .
This issue was identified while trying to replicate an RC branch and testing the workflows as part of #773.
Description of the Change:
#773 worked as expected with the changes introduced in this PR.
Links:
Benefits:
Auto on-boarding tested and working with this fix.
Possible Drawbacks:
Related GitHub Issues: