Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test to not fail with new shots validation #138

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

timmysilv
Copy link
Contributor

this test was halfway-fixed to stop using the analytic keyword once upon a time, but the False was accidentally left behind. With the new validation (introduced in PennyLaneAI/pennylane#4169) in _device.py when setting shots, this failed suddenly!

@timmysilv timmysilv requested a review from a team June 15, 2023 13:12
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #138 (6ca39e8) into master (44ed7cf) will decrease coverage by 99.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #138       +/-   ##
==========================================
- Coverage   99.14%   0.00%   -99.15%     
==========================================
  Files           8       8               
  Lines         352     352               
==========================================
- Hits          349       0      -349     
- Misses          3     352      +349     

see 8 files with indirect coverage changes

@albi3ro albi3ro merged commit 4ae014d into master Jun 15, 2023
@albi3ro albi3ro deleted the fix-old-test-refactor branch June 15, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants