Fix build docker with sqlite3 musl error #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now broken in latest `golang:alpine` image (from alpine3.18 to alpine3.19). Alpine 3.19 was released on 2023-12-07. [^1] It is shipped with gcc 13.2 and musl-dev 2.14. [^2] The LFS64 interfaces were marked as deprecated for musl 1.2.4. [^3] As a temporary workaround, builds broken by this change can be fixed short-term by adding `-D_LARGEFILE64_SOURCE` to `CFLAGS`, but should be fixed to use the standard interfaces, refer to go-sqlite3 issue 1164. [^4] --- [^1]: https://www.alpinelinux.org/posts/Alpine-3.19.0-released.html [^2]: https://pkgs.alpinelinux.org/packages?name=musl-dev&branch=v3.19 [^3]: https://git.musl-libc.org/cgit/musl/commit/?id=25e6fee27f4a293728dd15b659170e7b9c7db9bc [^4]: mattn/go-sqlite3#1164
Comment the `if` condition for 'deploy-docker' job temporarily, to run build docker image CI/CD job in non-main branch.
huiyifyj
added a commit
that referenced
this pull request
Dec 22, 2023
The commit 031e41a is a temporary workaround to fix musl build error, and now to remove `CGO_CFLAGS="-D_LARGEFILE64_SOURCE"` for building docker image, because go-sqlite3 library was upgraded to `1.14.19` [^1] and the musl build was fixed in go-sqlite3 version `1.14.19` [^2]. This reverts commit 031e41a (refer PR #234). --- [^1]: commit hash ad6673b [^2]: mattn/go-sqlite3#1177
huiyifyj
added a commit
that referenced
this pull request
Dec 23, 2023
Revert "Fix build docker with sqlite3 musl error (#234)" commit. The commit 031e41a is a temporary workaround to fix musl build error, and now to remove `CGO_CFLAGS="-D_LARGEFILE64_SOURCE"` for building docker image, because go-sqlite3 library was upgraded to `1.14.19` [^1] and the musl build was fixed in go-sqlite3 version `1.14.19` [^2]. This reverts commit 031e41a (refer PR #234). --- [^1]: commit hash ad6673b [^2]: mattn/go-sqlite3#1177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build docker error in github actions job#923.
This is now broken in latest
golang:alpineimage (from alpine3.18 to alpine3.19).Alpine 3.19 was released on 2023-12-07.1 It is shipped with gcc 13.2 and musl-dev 2.14.2
The LFS64 interfaces were marked as deprecated for musl 1.2.4.3
As a temporary workaround, builds broken by this change can be fixed short-term by adding
-D_LARGEFILE64_SOURCEtoCFLAGS, but should be fixed to use the standard interfaces, refer to go-sqlite3 issue#1164.Footnotes
Alpine 3.19.0 release note ↩
Package musl-dev ↩
musl git commit: remove LFS64 programming interfaces (macro-only) from _GNU_SOURCE ↩