This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PRIV] Add privacy CLI commands #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
724e125 to
ef950b8
Compare
Errorific
reviewed
Jan 17, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/ProtocolScheduleFactory.java
Outdated
Show resolved
Hide resolved
Errorific
reviewed
Jan 17, 2019
| import tech.pegasys.pantheon.ethereum.core.PrivacyParameters; | ||
| import tech.pegasys.pantheon.ethereum.vm.GasCalculator; | ||
|
|
||
| public class PrecompiledContractConfiguration { |
There was a problem hiding this comment.
Is there any utility to this class beyond holding 2 objects? Could its consumers take the gas calculator and privacy parameters separately without losing functionality?
Errorific
reviewed
Jan 17, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/ProtocolScheduleFactory.java
Outdated
Show resolved
Hide resolved
Errorific
reviewed
Jan 17, 2019
...c/main/java/tech/pegasys/pantheon/ethereum/mainnet/MainnetPrecompiledContractRegistries.java
Outdated
Show resolved
Hide resolved
Errorific
reviewed
Jan 17, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
NicolasMassart
suggested changes
Jan 17, 2019
There was a problem hiding this comment.
As indicated in the comment we are working on an update of the CLI guideline that will be released in the 0.9 version. This will introduce breaking changes and CLI components naming conventions. So to prevent a refactoring of this part of your code, you could already make the listed change (only one) to be sure it will easily fit in the next release. Thanks for your valuable contribution.
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
Errorific
reviewed
Jan 18, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/ProtocolSpecBuilder.java
Show resolved
Hide resolved
642a7c5 to
1125277
Compare
NicolasMassart
previously approved these changes
Jan 18, 2019
wanted to only approve CLI option related changes, but it seems that it validates all... so reverting.
64d29d2 to
fb706cc
Compare
5abb5bb to
0627dc1
Compare
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/core/PrivacyParameters.java
Outdated
Show resolved
Hide resolved
lucassaldanha
approved these changes
Jan 23, 2019
0627dc1 to
52757fe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add functionality to include privacy pre-compiled contract if privacy is enabled through CLI.
The purpose of the PR is to take the privacy CLI commands and appropriately include
PrivatePrecompiledContractto protocol spec. Currently the contract is stubbed.