This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-3009] Fixes invalid JsonGetter, comment #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf2f242 to
3dc5b45
Compare
rain-on
reviewed
Aug 5, 2019
| @@ -36,7 +36,7 @@ | |||
| }) | |||
| /* | |||
| The original deserialised private transaction sent via eea_sendRawTransaction | |||
| This class is used if the original request was sent with privateFrom and privateFor | |||
| This class is used if the original request was sent with privacyGroupId | |||
There was a problem hiding this comment.
It'd be good to update the comment in PrivateTransactionLegacyResult as well (same reason).
There was a problem hiding this comment.
This has now been addressed. Sorry for the delay.
CjHare
approved these changes
Aug 5, 2019
iikirilov
suggested changes
Aug 18, 2019
...gasys/pantheon/ethereum/jsonrpc/internal/results/privacy/PrivateTransactionLegacyResult.java
Outdated
Show resolved
Hide resolved
rain-on
approved these changes
Aug 27, 2019
pscott
pushed a commit
to pscott/pantheon
that referenced
this pull request
Sep 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes the following:
The json getter on line 49 is mislabeled
It should be changed from "privateFor" to "privacyGroupId"
Also, the comment above the class is not accurate