This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2953] Track world state account key preimages #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
reviewed
Jul 29, 2019
| * @return a stream of all the accounts (in no particular order) contained in the world state | ||
| * represented by the root hash of this object at the time of the call. | ||
| */ | ||
| Stream<Account> streamAccounts(); | ||
| Stream<Account> streamAccounts(Bytes32 startKeyHash, int limit); |
There was a problem hiding this comment.
Awesome, I had to fake this out on my end.
shemnon
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When new accounts are created, save the mapping from addressHash to address in
WorldStatePreimageStorage. This allows us to iterate over account values in the world state trie, filling in the account address from the preimage storage.