This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
simple account permissioning #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
suggested changes
May 8, 2019
| var payload = "0x1234"; | ||
|
|
||
| contract('Permissioning: Accounts', () => { | ||
| describe('Function: permissioning', () => { |
There was a problem hiding this comment.
There is no need to use contract() and describe()
https://truffleframework.com/docs/truffle/testing/writing-tests-in-javascript
| @@ -1,5 +1,7 @@ | |||
| var SimplePermissioning = artifacts.require("SimplePermissioning"); | |||
| var SimpleAccountPermissioning = artifacts.require("SimpleAccountPermissioning"); | |||
|
|
|||
| module.exports = function(deployer) { | |||
| deployer.deploy(SimplePermissioning); | |||
There was a problem hiding this comment.
Should we rename SimplePermissioning to SimpleNodePermissioning`?
Errorific
reviewed
May 8, 2019
| // DO NOT USE THIS CONTRACT IN PRODUCTION APPLICATIONS | ||
|
|
||
| contract SimpleAccountPermissioning { | ||
| address[] private whitelist; |
There was a problem hiding this comment.
While there's no need to return the whole whitelist I think it's easier to just make this mapping(address -> boolean) rather than do the array manipulation and looping
…-simple-account-perm-smart-contract
…-simple-account-perm-smart-contract
Errorific
reviewed
May 9, 2019
| permitted = await proxy.transactionAllowed(address1, address2, value, gasPrice, gasLimit, payload); | ||
| assert.equal(permitted, true, 'expected tx from address1 to still be permitted'); | ||
| }); | ||
| it('Should NOT permit any transaction when acount whitelist is empty', async () => { |
Errorific
approved these changes
May 9, 2019
…-simple-account-perm-smart-contract
lucassaldanha
approved these changes
May 9, 2019
…-simple-account-perm-smart-contract
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
* simple account permissioning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Added SimpleAccountPermissioning smart contract with tests
Fixed Issue(s)
fixes #PAN-2608