This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement max message size rather than limiting with fixed number of transactions #1271
Implement max message size rather than limiting with fixed number of transactions #1271
Changes from 23 commits
ffadf39
f9de190
2dfd4ac
1357795
b9052b5
1d07a42
2260bfe
16f21dc
2cf5cbd
058cea9
30020e0
3eccfb7
e7bf11e
40372be
398c3ab
0073f1e
40e15d6
bdefa72
07924dc
4d059cd
c8ca937
0f94204
8899e78
4066a17
2112b83
52cd58e
61579c8
038e4d4
6f3e08f
268e065
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional) You could also have LimitedTransactionsMessages.createLimited return a stream of
TransactionMessages
, then you don't need the extraremoveAll
bookkeeping and the extra memory for the included tx's list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you cut this assertion? I think it just ends up being confusing.