This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2352] Make alloc optional and provide nicer error messages when genesis config is invalid #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Mar 4, 2019
| nonce = nonce.substring(2); | ||
| } | ||
| return Long.parseUnsignedLong(nonce, 16); | ||
| return withNiceErrorMessage("mixHash", genesis.getMixHash(), Hash::fromHexStringLenient); |
There was a problem hiding this comment.
I assume you meant to make the mixHash parsing more lenient here^ ? Wonder if we should accept any zero-valued hash, and otherwise be strict ...
There was a problem hiding this comment.
Yes this was deliberate (as with parentHash). It's unlikely that it will make any difference but since the mix hash for the genesis file really doesn't matter (as long as it's the same for all nodes) it seems nice to not have to add all the digits for no real reason. It doesn't seem worth the extra code to specifically allow it only for 0x0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Allow the
allocelement in genesis configs to be omitted, defaulting to no allocations.Provide better error messages when items in the genesis config are invalid.