Current LSN : Account for NULL LSN value being returned #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently seen for a read replica mirror that the above
pglogrepl
function we use to get the current LSN returned an EOF error at the first check - indicating that the LSN string we were giving it was not of the right format.Upon research it seems like the functions in the query we run:
SELECT CASE WHEN pg_is_in_recovery() THEN pg_last_wal_receive_lsn() ELSE pg_current_wal_lsn() END
can return
NULL
as seen here for example.It seems that this can occur when there is no more WAL activity to collect, not sure
This PR simply adds more logging around this.