Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr messages.po #28

Closed
wants to merge 15 commits into from
Closed

fr messages.po #28

wants to merge 15 commits into from

Conversation

serpico
Copy link

@serpico serpico commented May 20, 2024

several strings added

@serpico serpico linked an issue May 20, 2024 that may be closed by this pull request
@serpico
Copy link
Author

serpico commented May 20, 2024

@minimalparts I've been wondering, line 728 to 732 from my PR #: app/templates/search/results.html:43 already appears in French in the UI, although not translated yet in messages.po

I guess it must comes from somewhere else...

@minimalparts
Copy link
Member

@serpico I had made a few additional changes on the test instance itself when I solved the issue with the captcha. I think you can just make your changes as you see fit and I will add one more commit at the end to smooth things over. Thank you!

@minimalparts
Copy link
Member

@serpico small question: had you re-run flask-babel on your installation? Just wondering why we also have a new German file :D (Which is good, btw, but I'm trying to figure out what happened.)

@serpico
Copy link
Author

serpico commented May 20, 2024

@serpico I had made a few additional changes on the test instance itself when I solved the issue with the captcha. I think you can just make your changes as you see fit and I will add one more commit at the end to smooth things over. Thank you!

I picked up your version as is and pasted it in my soon-to-be-pushed PR

@serpico
Copy link
Author

serpico commented May 20, 2024

@serpico small question: had you re-run flask-babel on your installation? Just wondering why we also have a new German file :D (Which is good, btw, but I'm trying to figure out what happened.)

Not that I know, I just sync-ed your 22-translations branch to make sure I have the latest version before making my edits.

@serpico serpico closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations
3 participants