Add support for password protected ACL users #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ACL suport to the redis-cli wrapper - Added ACL setup with disabled default user and password protected users - Added envvars for the admin user used by the operator
shyimo
reviewed
Jun 28, 2021
| user := os.Getenv("REDIS_USERNAME") | ||
| if user != "" { | ||
| cli.Auth = &rediscli.RedisAuth{ | ||
| User: user, |
There was a problem hiding this comment.
where is the REDISCLI_AUTH (password) usage ?
There was a problem hiding this comment.
Same answer as here:
#106 (comment)
There was a problem hiding this comment.
i understand now. so i would like to prevent from the operator to start when REDIS_USERNAME was supplied but
REDISCLI_AUTH env variable is not set. you can throw an error (with log) here in case this apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users
Part of #100