Please review these changes for inclusion #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 14, 2015 15:12
When only called to test touch() that can leave after 5 SPI words. Existing code reads all 10 words then does the x,y Point math and does not store or return the calculated value.
This reverts commit 71a6965.
On initializing with interrupt pin Poll calls for touch are ignored unless preceded by falling edge on touch interrupt pin. User calls are honored until touch detection records a failed pressure test reading. This allows the user code to call at a faster rate with no SPI impact so that the start of a touch is not missed like when polled at a conservative 100ms. Included TouchTest sample modified for continuous loop() read to demonstrate responsiveness and no SPI chatter, versus bright LED when int pin is not used.
PaulStoffregen
added a commit
that referenced
this pull request
Nov 26, 2015
Please review these changes for inclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change of 20 lines uses interrupt pin to gate the actual touch reading.
I tried to fit it into the PJRC code model - there is one exposed value that would allow user code to disable touch reading (until next interrupt if enabled)
Putting the CPP class code as an ISR was done based on FrankB's personal usage.
On interrupt only a BOOLEAN flag is set.
Doing anything more complex enters the realm of race condition cascading interrupts.
The boolean goes false AFTER the prior SPI read is detects NO_TOUCH, which will have triggered the interrupt in the process. DIsabling it then will set it false, preventing added SPI reads of touch until the interrupt falls again.
I have tested this to work with T_3.1 and T_LC. LC works on TouchTest, I also tested on a complex graphics button example with LC and AdaFruit driver.