Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardhat migration #6

Merged
merged 6 commits into from
Nov 17, 2020
Merged

Conversation

TomAFrench
Copy link
Contributor

@TomAFrench TomAFrench commented Nov 9, 2020

Changelog:

@PaulRBerg
Copy link
Owner

PaulRBerg commented Nov 10, 2020

Whoah, thanks for this dude! I'll test the integration as soon as solidity-coverage is available.

@TomAFrench
Copy link
Contributor Author

Looks like solidity-coverage support is here.

@PaulRBerg
Copy link
Owner

Yeah this is on my to-do list.

@PaulRBerg
Copy link
Owner

It looks like there is a mismatched dependency:

hardhat-typechain@0.3.3" has incorrect peer dependency "typechain@^3.0.0"

I'll fix it myself and push to your branch.

@PaulRBerg
Copy link
Owner

PaulRBerg commented Nov 17, 2020

One thing that I really don't like is including hardhat-spdx-license-identifier. It's an opinionated tool that doesn't add much value - the Solidity compiler would warn the user about the missing SPDX identifiers anyways.

It adds these superfluous logs when running the compile and coverage scripts:

Prepended SPDX License Identifier "WTFPL" to 0 sources.
Compiling 2 files with 0.7.4
Compilation finished successfully
Creating Typechain artifacts in directory typechain for target ethers-v5
Successfully generated Typechain artifacts!
Prepended SPDX License Identifier "WTFPL" to 0 sources.
Creating Typechain artifacts in directory typechain for target ethers-v5
Successfully generated Typechain artifacts!

build: install correct peer deps for typechain
@PaulRBerg PaulRBerg merged commit 877b72a into PaulRBerg:main Nov 17, 2020
@PaulRBerg PaulRBerg changed the title WIP: Hardhat migration Hardhat migration Nov 17, 2020
@TomAFrench TomAFrench deleted the hardhat-migration branch November 17, 2020 21:25
@TomAFrench
Copy link
Contributor Author

TomAFrench commented Nov 17, 2020

One thing that I really don't like is including hardhat-spdx-license-identifier. It's an opinionated tool that doesn't add much value - the Solidity compiler would warn the user about the missing SPDX identifiers anyways.

Fair enough. I find it useful but definitely see why others may feel otherwise.

Agree on the 0 sources messages though. May make a PR for that at some point

@PaulRBerg
Copy link
Owner

Yeah if they remove that message, happy to add it back.

This was referenced Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants