Cause CI failure in case of rustdoc warnings #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulDance
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Hi again, so quick! 😄
Thanks for this, it was exactly what I was looking for initially but couldn't find in the end. Insta-merge material, for sure!
It may make the workflow fail after merging, unless you already fixed the warning in the previous PR 🤔
I'll fix it myself if does indeed fail.
Thanks!
|
Already fixed in 9ca4844 ❤️ |
|
Released as part of v0.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rustdoc warnings don't cause the CI to fail
Sample failure: https://github.com/MaeIsBad/cargo-liner/actions/runs/5255463647/jobs/9495416222