ignore locally installed packages when importing #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulDance
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Hey, thanks for the additional contribution!
A bunch of small things to address, but the core of it is good.
Corresponding integration tests should be added as well. The tests/import.rs module includes already includes a few of them. You should therefore be able to relatively easily write the various combinations needed.
PaulDance
requested changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #21
Currently, I kept the source origin as a String since I wasn't able to find a list of all possible variants and I didn't want to create an enum with path, registry, and other
I also have overwritten the shorthand for
--with-localsince 'w' feels a bit off