[Search git status] fix extra quotes around paths with space #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickF1
commented
Mar 19, 2022
| @@ -1,5 +1,6 @@ | |||
| set --global --export SHELL /bin/sh | |||
| # don't set FZF_DEFAULT_OPTS so it will set one | |||
| # erase FZF_DEFAULT_OPTS so that one will be set by the wrapper function | |||
| set --erase FZF_DEFAULT_OPTS | |||
There was a problem hiding this comment.
out of scope change to facilitate local tests where I do have a FZF_DEFAULT_OPTS set already
PatrickF1
commented
Mar 19, 2022
| @@ -25,7 +25,7 @@ function _fzf_search_git_status --description "Search the output of git status. | |||
| end | |||
| end | |||
|
|
|||
| commandline --current-token --replace -- (string escape -- $cleaned_paths | string join ' ') | |||
There was a problem hiding this comment.
Turns out string escape is unnecessary because git status already escapes filenames with spaces in them
PatrickF1
commented
Mar 19, 2022
| @@ -1,10 +1,11 @@ | |||
| set files "filename_with_*.txt" "filename with space.csv" | |||
| set files "filename_with_*.txt" "filename with space.csv" tests/_resources/nestedfilename | |||
There was a problem hiding this comment.
updated test to also test it works for nested filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where file paths outputted by search git status include an extra layer of single quotes if the path includes a space. Turns out this is because we string escape all our paths before writing them to the command line but git status already string escapes paths with spaces.
Fixes #220