[Search processes] allow multi-selection and clean up code a little #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickF1
commented
Jan 30, 2022
|
|
||
| ### A commit hash | ||
| ### Commit hashes |
There was a problem hiding this comment.
This and Shell variables header should have been plural to represent the ability to select multiple of them
PatrickF1
commented
Jan 30, 2022
| @@ -1,18 +1,21 @@ | |||
| function _fzf_search_processes --description "Search all running processes. Replace the current token with the pid of the selected process." | |||
| set token (commandline --current-token) | |||
There was a problem hiding this comment.
moved into the call to _fzf_wrapper to simplify
PatrickF1
commented
Jan 30, 2022
| --ansi \ | ||
| --header-lines=1 \ | ||
| --preview='ps -o pid,user,ppid,%cpu,rss,time,start,command -p {1}' \ | ||
| $fzf_processes_opts | ||
| ) | ||
|
|
||
| if test $status -eq 0 | ||
| set pid_selected (string split --no-empty " " $process_selected)[1] | ||
| commandline --current-token --replace -- (string escape -- $pid_selected) |
There was a problem hiding this comment.
string escape was unnecessary
PatrickF1
commented
Jan 30, 2022
| @@ -7,7 +7,7 @@ function fzf_configure_bindings --description "Installs the default key bindings | |||
| set options_spec h/help 'directory=?' 'git_log=?' 'git_status=?' 'history=?' 'variables=?' 'processes=?' | |||
| argparse --max-args=0 --ignore-unknown $options_spec -- $argv 2>/dev/null | |||
| if test $status -ne 0 | |||
| echo "Invalid option or a positional argument was provided." 1>&2 | |||
| echo "Invalid option or a positional argument was provided." >&2 | |||
There was a problem hiding this comment.
out of scope change to make writing to stderr more consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.