[Search directory] fix specifying base directories using quotes #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can I repro the bug? |
|
I don't consider it a bug, though technically it did stop working. To reproduce, just input |
|
Hmm I was able to repro. But you know what? I vaguely remember changing |
If it breaks anything we should fix it instead. However this only affects the string match and I don't see any other issue. |
|
Did some more testing and it seems to not break anything. If it does introduce a new bug, I trust you to find it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was presented in the initial PR when the feature is added, but was (possibly mistakenly) broken by #137.