Make preview directory command configurable #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickF1
commented
Feb 6, 2021
| @@ -3,8 +3,13 @@ function __fzf_preview_file --argument-names file_path --description "Print a pr | |||
| if test -f "$file_path" # regular file | |||
| bat --style=numbers --color=always "$file_path" | |||
| else if test -d "$file_path" # directory | |||
| set --local CLICOLOR_FORCE true | |||
There was a problem hiding this comment.
This wasn't working and I couldn't figure out a way to pass in CLICOLOR_FORCE while still using command to execute ls (which is necessary when people have ls aliased to something else), so I am removing it. Hopefully, passing in the additional -F will compensate a bit for the lack of colors.
hrshtst
pushed a commit
to hrshtst/fzf.fish
that referenced
this pull request
Apr 22, 2021
To acquiesce to the popularity and diversity of ls alternatives (e.g. https://github.com/ogham/exa, https://github.com/Peltoche/lsd, https://github.com/athityakumar/colorls, tree, all of which have many different options to configure them), I have finally decided to make the command used to preview directories configurable. Users can place their desired command in fzf_preview_dir_cmd and fzf.fish will use it. Related to PatrickF1#117 and PatrickF1#101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To acquiesce to the popularity and diversity of ls alternatives (e.g. https://github.com/ogham/exa, https://github.com/Peltoche/lsd, https://github.com/athityakumar/colorls, tree, all of which have many different options to configure them), I have finally decided to make the command used to preview directories configurable. Users can place their desired command in fzf_preview_dir_cmd and fzf.fish will use it.
Related to #117 and #101