feat(api): add jitter to cron jobs, paging support, and backoff handling #33
Conversation
There was a problem hiding this comment.
Seems legit! Not tested locally yet. Will try later.
Jitter only for slowPoll (every 7+-2 minutes) that gathers yearly energy. Tried to get 5000 pages all at once at same clockhours. I had no trouble with this, but it is good to filter out noise in the API and also have reliable data every 7 minutes.
Should there be jitter on pollValues too? They are much more frequent.
Love the backoff logic.
Good work!
| @@ -36,7 +37,13 @@ export class GoCharger extends Homey.Device { | |||
| this.cronTasks.push( | |||
| cron.schedule('0,30 * * * * *', () => this.pollValues()), | |||
There was a problem hiding this comment.
Should there be a jitter on pollVales too? Run every whole and half minute. Same for all users I think.
There was a problem hiding this comment.
Hi, jitter is helpful on every job that is running on the schedule, but it makes more difference on any request that potentially has big response body (just due to the memory constraints on the backend when you have too many in-flight requests).
We will have a look there after we inspect the workload from Homey more closely.
Thanks for the good work and merry Christmas!
| @@ -257,11 +265,11 @@ export class GoCharger extends Homey.Device { | |||
| ChargerId: this.getData().id, | |||
| From: new Date(year, 0, 1, 0, 0, 1).toJSON(), | |||
| DetailLevel: 0, | |||
| PageSize: 5000, | |||
| PageSize: 50, | |||
There was a problem hiding this comment.
Good. This halves the response time.
|
Hello everyone! Very nice to see some contributions here. This looks all nice and dandy to me. I've lost access to Zaptec devices so I'm unable to verify it myself locally. However, I can't see any issues with this :) I'll merge and push! |
Hello, Zaptec devs are here!
We see some issues with the current implementation of the app from our side (for example scheduled fetch of the data is failing).
We would like to help with a reliability of the plugin for Homey users, and to do so, the following changes are proposed:
These changes enhance API robustness and prevent potential overloading while ensuring compatibility with paginated responses. We hope that these changes will be beneficial for all Homey users and will improve the overall experience with the Zaptec app.
We deeply appreciate the time and expertise that go into maintaining and improving the Homey plugin, and we're excited to do a small contribution to its continued success.