Only apply dual wield penatly for on weapon triggers requiring attack sources #7137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8146cf5 to
9bd7f9e
Compare
LocalIdentity
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://www.reddit.com/r/pathofexile/comments/188r65t/why_does_pob_cut_my_trigger_rate_for_coc_when/ke93zcv/
Description of the problem being solved:
It seems the interaction between dual wielding and triggers is incorrect in POB. Not really sure how to implement dual wielding interactions for triggers such as The Poet's Pen or Cospri's Malice or if that interaction is even in scope of pob simulations so marking as draft for now.