Fix gem mods on Forbidden Shako not working correctly with Utula's Hunger #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Shako is currently disabling Utula's maximum life when it has a mod that has the word life in it including "Proliferation"
These mods only have the Gem tag.
Hybrid mods from Shaper and Elder seem to have additional tags but these appear to be due to the other line that accompanies them.
E.g. Socketed Gems are Supported by Level X Minion Life (provides the gem tag)
Minions have X% increased maximum Life (hypothesis is that this provides the life and minion tag on the mod)
Proposed solution is to exclude all "socketed gems are supported by" mods from the Utula check.
It was also mentioned that hybrid mods are parsed as two separate lines anyway so the above minion life mod would still fail the Utula check.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: