-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show accuracy above hit chance when using Precise Technique #6034
Show accuracy above hit chance when using Precise Technique #6034
Conversation
Would it be better to represent these as main hand hit chance and off hand hit chance instead and hide regular hit chance? Then you can hide regular on OH != MH and hide OH and MH when OH == MH. |
This isn't about Hit Chance, it's purely so you can compare the values of Accuracy Rating to Total Life more easily/without needing to go to the Calcs Tab. I believe Hit Chance today is already accounting for two weapons of different accuracies. |
Perhaps just generate a warning Just some random thoughts :) |
I think having the actual accuracy rating always show, when Precise Technique is allocated, is preferable to a warning. |
9c95766
to
8a9dd09
Compare
Was thinking of the display in the Calcs tab. Oops. |
Description of the problem being solved:
Adding a little QoL for Precise Technique users, normally when playing around with the tree or items or some configuration you would need to flip over to the Calcs tab to track down exact accuracy. With this, MainHand (and OffHand if using) Accuracy is displayed above Hit Chance in the sidebar stats given the keystone is allocated. Strictly a conditional displayStat.
I'm not 100% certain the CalcOffense change is in the best location to set whether Precise Technique is allocated but I figured it's inside the "isAttack" and around the MainHand/OffHand calcs so it's a safe bet.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
Commit 4: Position updated to be above Life:
Commit 5 update, warning and color change