Export cluster jewel index data, mess with jewel rendering logic #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2728 |
2 tasks
sida-wang
added a commit
to sida-wang/PathOfBuilding
that referenced
this pull request
Jan 20, 2024
- Tidy up in BuildClusterJewelGraphs() to prevent allocSubgraphNodes and allocExtendedNodes from having duplicate nodes - Add in orbitOffsets into ClusterJewels.lua via export. Credit to Wires77 PathOfBuildingCommunity#4302 for figuring this out - Update the logic that calculates the orbitIndex in BuildSubgraph to use orbitOffsets
LocalIdentity
pushed a commit
that referenced
this pull request
Jan 21, 2024
* fix: cluster jewel imports not working - Tidy up in BuildClusterJewelGraphs() to prevent allocSubgraphNodes and allocExtendedNodes from having duplicate nodes - Add in orbitOffsets into ClusterJewels.lua via export. Credit to Wires77 #4302 for figuring this out - Update the logic that calculates the orbitIndex in BuildSubgraph to use orbitOffsets * Revert launch.lua --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Importing characters did not always allocate cluster jewels properly, due to nodes having an incorrect orbitIndex
Steps taken to verify a working solution: