Several fixes to make it work as a drop in replacement for roscore #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for the RiiR :)
I found a few issues / behavior differences from the original roscore implementation and fixed them, so that ros-core-rs can be used as a drop-in replacement.
Things i changed:
While the test coverage is not extensive, we have tested this in our existing robot and so far have not found any more bugs. CPU usage is reduced significantly compared to the upstream roscore implementation in scenarios that put load on roscore, such as repeated querying for parameters. Incidentally, ros-core-rs's logs (with
RUST_LOG=ros_core_rs=debug
) turned out to be more useful than the log file of the original implementation in locating such bottlenecks and fix the underlying issue (repeated querying of parameters).