Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting TimeToBeReceived in the metrics configuration does not set the corresponding TimeToLive value #307

Merged
merged 1 commit into from
May 22, 2024
Merged

Setting TimeToBeReceived in the metrics configuration does not set the corresponding TimeToLive value #307

merged 1 commit into from
May 22, 2024

Conversation

mauroservienti
Copy link
Member

@mauroservienti mauroservienti commented May 22, 2024 •
edited
Loading

The Metrics configuration, like all the other configuration options, exposes a way to set the metric message time to live.

Instead of using the canonical TimeToLive property, it's using TimeToBeReceived.

This PR fixes the bug by introducing a new TimeToLive property and obsoleting the wrong one.

@mauroservienti @bording
Obsolete TimeToBeReceived and forward to TimeToLive
fddf99b 
Co-Authored-By: Brandon Ording <bording@gmail.com>
@mauroservienti mauroservienti self-assigned this May 22, 2024
@mauroservienti mauroservienti mentioned this pull request May 22, 2024
Closed
@mauroservienti mauroservienti added the Bug Something isn't working label May 22, 2024
@mauroservienti mauroservienti added this to the 2.0.2 milestone May 22, 2024
@danielmarbach danielmarbach merged commit 78a359e into release-2.0 May 22, 2024
3 checks passed
@danielmarbach danielmarbach deleted the backport-283-to-r2 branch May 22, 2024 12:45
@danielmarbach danielmarbach changed the title [Backport 283 to release-2.0] Metrics configuration wrongly exposes TimeToBeReceived instead of TimeToLive Metrics configuration wrongly exposes TimeToBeReceived instead of TimeToLive May 22, 2024
@mauroservienti mauroservienti changed the title Metrics configuration wrongly exposes TimeToBeReceived instead of TimeToLive Setting TimeToBeReceived in the metrics configuration does not set the corresponding TimeToLive value May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmarbach danielmarbach danielmarbach approved these changes

@bording bording Awaiting requested review from bording

Assignees

@mauroservienti mauroservienti

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mauroservienti @danielmarbach