-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify generated scripts to static script #68
Conversation
DavidBoike
commented
Jul 11, 2019
- Prepares for new major version 4.0
- Removes the code generation and MSBuild stuff, making the MsBuild package only create an error instructing the removal of the package. After release of 4.0, the MsBuild package stuff needs to be removed as well so that 4.0.0 is the last release.
- Adds the .ps1 script as a static resource of the package that will be added to the build output.
- Removes the C# script. Most customers should use Powershell, and this can cause issues for customers when a code file dropped in build output directories anyway, as it sometimes runs afoul of security infrastructure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed up some tweaks and left some comments.
It appears that something caused the file permissions to be changed. Those should be reverted.
Also, the API approval test needs to be updated.
@@ -1,7 +1,7 @@ | |||
|
|||
#requires -RunAsAdministrator | |||
Function InstallNSBPerfCounters { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CreateNSBPerfCounters.ps1
the name of the file that the old generation code would create?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, now that we're bumping the major we could change it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave that up to you.