Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateInterval proper obsoletion #42

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Conversation

Scooletz
Copy link
Contributor

@Scooletz Scooletz commented Nov 7, 2017

This PR addresses #24 by adding an empty method that is obsoleted and ready to be removed in version 3.0

API was removed in here https://github.com/Particular/NServiceBus.Metrics.PerformanceCounters/blob/00d6271b8bf7f35f3d2dd04dfb2615ea4e8db6e8/src/NServiceBus.Metrics.PerformanceCounters.Tests/NServiceBus.Metrics.PerformanceCounters.approved.cs without a proper obsolete. This PR changes it

@Scooletz Scooletz requested a review from a team November 7, 2017 09:50
@Scooletz Scooletz self-assigned this Nov 7, 2017
Copy link
Contributor

@seanfarmar seanfarmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanfarmar seanfarmar merged commit 3821d5f into develop Nov 7, 2017
@Scooletz Scooletz deleted the update-interval-obsoletion branch November 7, 2017 12:13
@Scooletz Scooletz added this to the 2.0.0 milestone Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants