Performance counter creation script always deletes nservicebus category
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Particular/metrics-maintainers Could you take a look whether this is a valid approach that we want to pursuit? |
22f66d3 to
aa50f5f
Compare
c1d5fe6 to
f7cabd2
Compare
nservicebus category
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #25
This PR changes the way, in which performance counters are created. It introduces changes that, before aggressive category recreation, check whether all the required counters are created. If yes, the recreation is postponed. This approach has been inspired by NServiceBus.PowerShell.
See #25 for more details.