Skip to content

Commit

Permalink
Moving the logs after data.yaml warning, and removing unnecessary bla…
Browse files Browse the repository at this point in the history
…nk lines.

Signed-off-by: Parth Mandaliya <parthx.mandaliya@intel.com>
  • Loading branch information
ParthM-GitHub committed Sep 28, 2023
1 parent de2e333 commit 880b7a3
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions openfl/experimental/interface/cli/aggregator.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ def start_(plan, authorized_cols, secure):
plan = Plan.parse(plan_config_path=Path(plan).absolute(),
cols_config_path=Path(authorized_cols).absolute())

logger.info('🧿 Starting the Aggregator Service.')

if not os.path.exists('plan/data.yaml'):
logger.warning(
'Aggregator private attributes are set to None as plan/data.yaml not found'
Expand All @@ -70,6 +68,8 @@ def start_(plan, authorized_cols, secure):
'Aggregator private attributes are set to None as no aggregator'
+ ' attributes found in plan/data.yaml.')

logger.info('🧿 Starting the Aggregator Service.')

agg_server = plan.get_server()
agg_server.is_server_started = False
agg_grpc_server = threading.Thread(target=agg_server.serve)
Expand Down Expand Up @@ -191,14 +191,12 @@ def certify(fqdn, silent):
crt_path_absolute_path = Path(CERT_DIR / f'{cert_name}.crt').absolute()

if silent:

echo(' Warning: manual check of certificate hashes is bypassed in silent mode.')
echo(' Signing AGGREGATOR certificate')
signed_agg_cert = sign_certificate(csr, signing_key, signing_crt.subject)
write_crt(signed_agg_cert, crt_path_absolute_path)

else:

echo('Make sure the two hashes above are the same.')
if confirm('Do you want to sign this certificate?'):

Expand Down

0 comments on commit 880b7a3

Please sign in to comment.