Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error when setting up COA #71

Conversation

Alchez
Copy link

@Alchez Alchez commented Feb 14, 2023

Based on errors while setting up the Parsimony app

Traceback (most recent call last):
  File "/home/runner/parsimony-bench/apps/frappe/frappe/commands/utils.py", line 258, in execute
    ret = frappe.get_attr(method)(*args, **kwargs)
  File "/home/runner/parsimony-bench/apps/parsimony/parsimony/setup.py", line 65, in setup_instance
    import_parsimony_coa(data)
  File "/home/runner/parsimony-bench/apps/parsimony/parsimony/setup.py", line 372, in import_parsimony_coa
    forest = build_forest(csv_reader)
  File "/home/runner/parsimony-bench/apps/erpnext/erpnext/accounts/doctype/chart_of_accounts_importer/chart_of_accounts_importer.py", line 269, in build_forest
    path = return_parent(data, account_name)
  File "/home/runner/parsimony-bench/apps/erpnext/erpnext/accounts/doctype/chart_of_accounts_importer/chart_of_accounts_importer.py", line 229, in return_parent
    return [child] + parent_account_list
TypeError: can only concatenate list (not "NoneType") to list

@Alchez Alchez requested a review from vjFaLk February 14, 2023 10:06
@commit-lint
Copy link

commit-lint bot commented Feb 14, 2023

Bug Fixes

  • type error when setting up COA (4474b74)

Contributors

Alchez

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@vjFaLk vjFaLk merged commit b2eff59 into ParsimonyGit:parsimony-production-v14 Feb 14, 2023
@Alchez Alchez deleted the fix-chart-of-accounts-tree branch May 14, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants