Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imitation fix 2 #28318

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Imitation fix 2 #28318

merged 3 commits into from
Feb 10, 2025

Conversation

Spaghetti-bit
Copy link
Contributor

What Does This PR Do

Fixes corrupted save slots and machine surgery for imitation.

Why It's Good For The Game

Again, this is my fault. Fixes are good.

Testing

This is after changing character slots, changing species from one to another, changing the subtype, then swapping over. Repeating this in random orders to truly test it all.
image

Proof of IPC machine configuration fixes. This broke after I changed how the proc took in parameters. fixed now.
image


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixed IPC imitation surgery (Still done by targeting head -> Identity Reconfiguration)
fix: Fixed corrupted save slots caused by swapping slots or subtypes of species.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 10, 2025
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eagmerge

@lewcc lewcc added this pull request to the merge queue Feb 10, 2025
Merged via the queue into ParadiseSS13:master with commit 313cf60 Feb 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants