Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better atmos init #28274

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Better atmos init #28274

merged 1 commit into from
Feb 8, 2025

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Removes an unnecessary blind_set_air on turf init.
Makes air alarms not fire until a MILLA tick has passed.
Makes roundstart N2O/plasma visible.

Why It's Good For The Game

Correctness good, unnecessary work bad.

Testing

Started game. Saw stuff in atmos tanks. Air alarms didn't panic about lack of air.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: The Shadow should no longer randomly have its fire alarms triggered.
fix: Roundstart N2O/plasma is now visible.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 6, 2025
@FunnyMan3595 FunnyMan3595 added Fix This PR will fix an issue in the game Performance This will increase performance on the server labels Feb 6, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 6, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 6, 2025
@Burzah Burzah added this pull request to the merge queue Feb 8, 2025
Merged via the queue into ParadiseSS13:master with commit 36139a6 Feb 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game Performance This will increase performance on the server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants