Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet test activate_self wrapper and negative any_chatlog check #28209

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Feb 1, 2025

What Does This PR Do

Adds an activate_self wrapper and a negative check for any_chatlog for game tests,

Taking suggestions for their naming cause I suck at it!

Why It's Good For The Game

Could wind up useful for game tests

Images of changes

Negative any_chatlog check
Code_i9kYhWjWIa

failed activate_self check
image

Testing

checked that they run and that they fail.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@Toastical Toastical changed the title Adds an activate_self wrapper and a negative check for any_chatlog for game tests Puppet test activate_self wrapper and negative chatlog check Feb 1, 2025
@Toastical Toastical changed the title Puppet test activate_self wrapper and negative chatlog check Puppet test activate_self wrapper and negative any_chatlog check Feb 1, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 1, 2025
@Toastical
Copy link
Contributor Author

it was agreed to not be made a define

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 2, 2025
@Burzah Burzah added this pull request to the merge queue Feb 2, 2025
Merged via the queue into ParadiseSS13:master with commit a959de5 Feb 2, 2025
17 checks passed
@Toastical Toastical deleted the some-game-test-stuff branch February 6, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants