Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LORE] Replaces all uses of the word "intergalactic" in code #28203

Merged
merged 3 commits into from
Feb 10, 2025
Merged

[LORE] Replaces all uses of the word "intergalactic" in code #28203

merged 3 commits into from
Feb 10, 2025

Conversation

PopeDaveThe3th
Copy link
Contributor

What Does This PR Do

Title. Rewrites a few lines and descriptions to ensure the removal doesn't break anything.

Why It's Good For The Game

Nothing on our station is coming from outside the galaxy. The galaxy is very big. We are not.

Testing

  • loaded in
  • observed words
  • success

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Replaced intergalactic with better words
/:cl:

@PopeDaveThe3th PopeDaveThe3th changed the title [LORE] Replaces all uses of the word "intergalactic" from code [LORE] Replaces all uses of the word "intergalactic" in code Jan 31, 2025
@Coolrune206
Copy link
Contributor

The Syndie org specifically being called Intergalactic is fine because, when has a word being "incorrect" ever stopped a corporation from using it because it sounds good to consumers?

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 31, 2025
@ItsMarmite
Copy link
Contributor

Messaging and Intergalactic Letters is a fun acronym. At the very least replace Intergalactic with Interstellar. The replacement name is awful.

@PopeDaveThe3th
Copy link
Contributor Author

Acronym has been kept as per discussion in coding chat.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 31, 2025
@Burzah Burzah added this pull request to the merge queue Feb 10, 2025
@Burzah Burzah added the Lore This PR changes or adds new lore to the game. label Feb 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 10, 2025
Merged via the queue into ParadiseSS13:master with commit 3ace66e Feb 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spaghetti-bit Spaghetti-bit Spaghetti-bit approved these changes

@Burzah Burzah Burzah approved these changes

@Fordoxia Fordoxia Fordoxia approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Lore This PR changes or adds new lore to the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PopeDaveThe3th @Coolrune206 @ItsMarmite @Spaghetti-bit @Burzah @Fordoxia @ParadiseSS13-Bot