Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scope runtime if user loses the tracker #28202

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

Erikos66
Copy link
Contributor

What Does This PR Do

Stops the runtime in process() by checking if the tracker is valid before trying to get the owner.

Fixes #28165

Why It's Good For The Game

Runtimes are bad, validity checks are good.

Testing

Tested on a local server, shoot myself which applied the knockdown. Did NOT runtime.

scopefix.mp4

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 31, 2025
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just suppresses the runtime, the proc is still called on process

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 31, 2025
@Burzah Burzah added this pull request to the merge queue Feb 2, 2025
Merged via the queue into ParadiseSS13:master with commit dc15477 Feb 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lwap runtimes if you hit yourself with a shot that'll knock you down
6 participants