Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Mice: Let's populate maintenance randomly #28178

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Vi3trice
Copy link
Contributor

What Does This PR Do

This creates a step in the late mapping process where mice are spawned in maintenance randomly, with a random ratio range. Instead of just placing them manually, let the game do it for you unless you have really specific spots in mind.

Current ratios are 125 to 200 valid maintenance turfs per mice, making it range from 20 to 30 on Boxstation.

Maps are edited to remove all mice except for Tom, as the current fixed spawns would be excessive on top of the random ones (Except for Delta, which has a notable lack of mice). Let me know if there's some that should remain, or if the ratio should be tweaked.

Why It's Good For The Game

Mice being hard placed essentially means they'll have the same outcome most of the time (i.e. chew on the same cable every round). This changes things up, and is not reliant on dropping random spawners.

Images of changes

Rats
Rats2

Testing

Launched an instance, and looked around for mice.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added dynamic spawning of mice in maintenance on new rounds.
del: Removed fixed spawn points for mice (Except Tom) in all stations.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 29, 2025
@Drsmail
Copy link
Contributor

Drsmail commented Jan 30, 2025

Really love your idea! One thing, can i ssk you to read this and include necessary files, for smoth experience on downstream? We have different maps.

https://github.com/ParadiseSS13/Paradise/tree/master/tools/UpdatePaths

P.S. I forgot you need to leave some special mouses, not sure now if it can be done with this tool

Copy link
Contributor

@Drsmail Drsmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go as it is. But you might wanna check my comment and maybe give it a slight improvement

@Vi3trice Vi3trice requested a review from Contrabang January 30, 2025 23:40
@Burzah Burzah added this pull request to the merge queue Feb 10, 2025
Merged via the queue into ParadiseSS13:master with commit aa6cb23 Feb 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants