Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects the pressure readouts on non-detailed gas reports #28174

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Migratingcocofruit
Copy link
Contributor

What Does This PR Do

non-detailed gas reports sum the pressure instead of calculating with the total volume and temp.

Why It's Good For The Game

Fixes a bug

Images of changes

Testing

  • Scanned small and large pipenets and compared the received value to one manually calculated using the detailed report

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Corrects the pressure shown on non-detailed gas scan reports.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting review This PR is awaiting review from the review team label Jan 29, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 29, 2025
@Burzah Burzah added this pull request to the merge queue Jan 30, 2025
Merged via the queue into ParadiseSS13:master with commit f47f0de Jan 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants