Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mice not chew cables through catwalks #28157

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Vi3trice
Copy link
Contributor

What Does This PR Do

Due to a quirk of catwalks, they are technically valid for mice eating cables. This adds another check to prevent that, and at the same time rework the proc into early returns.

IC justification? They're chunky mice.

Why It's Good For The Game

Fixes #27943

Images of changes

tasty

Testing

Boxed in a mouse over catwalks and cables, then removed a catwalk. No animals were harmed.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Mice won't eat cables through catwalks anymore
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 28, 2025
@1080pCat
Copy link
Contributor

I'm kinda really iffy on this, there's honestly no real reason why mice /shouldn't/ be able to eat the cables, and repairing it isn't harder or anything, its like.. an extra four clicks if that.

@Fordoxia
Copy link
Contributor

I'm kinda really iffy on this, there's honestly no real reason why mice /shouldn't/ be able to eat the cables, and repairing it isn't harder or anything, its like.. an extra four clicks if that.

Wanting to protect cables without turning the area into normal flooring.

@1080pCat
Copy link
Contributor

I'm kinda really iffy on this, there's honestly no real reason why mice /shouldn't/ be able to eat the cables, and repairing it isn't harder or anything, its like.. an extra four clicks if that.

Wanting to protect cables without turning the area into normal flooring.

If you want to protect your tiles, using tiles that have holes in them isn't going to.
Something something eating cut cake, i get that the catwalks add to the theme of maints, but like.. so does mice chewing wires. It goes either unnoticed, or fixed rather quickly

@1080pCat 1080pCat added the Tweak This PR tweaks something ingame label Jan 28, 2025
@Burzah Burzah added Fix This PR will fix an issue in the game and removed Tweak This PR tweaks something ingame labels Jan 28, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 28, 2025
@Burzah
Copy link
Member

Burzah commented Jan 28, 2025

This has been ruled a fix, rather than a tweak. This will not be subject to a team vote.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 29, 2025
@Burzah Burzah added this pull request to the merge queue Jan 30, 2025
Merged via the queue into ParadiseSS13:master with commit 1a2f97c Jan 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mice can chew cables through catwalk tiles
6 participants