Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM sanity at low pressure #28152

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Adjust the SM gas production method to avoid producing a ridiculous output when active and at very low pressure.

Why It's Good For The Game

SM should not go supernova because it was low pressure.

Testing

Procedure:

  1. Disable engine bypass.
  2. Enable and maximize the engine input/output pipes.
  3. Configure the air alarm normally. This will create a vacuum in the chamber.
  4. Fire one emitter shot at the SM.
  5. Set the output speed on one N2 tank's pump to 9 kPa.
  6. Turn on that pump.

Results without this change:
image
and worsening. It will quickly reach a state that's effectively unsalvageable.

Results with this change:
image
and stable.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixed a bug that would cause the SM to go haywire if it was ever active and exposed to an extremely low (but nonzero) amount of gas.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 27, 2025
@1080pCat 1080pCat added the Fix This PR will fix an issue in the game label Jan 28, 2025
@Burzah Burzah added this pull request to the merge queue Feb 2, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 2, 2025
Merged via the queue into ParadiseSS13:master with commit 1911df9 Feb 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants