Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports TG lazy-loading of map templates using turf reservations #28101

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Jan 25, 2025

What Does This PR Do

Ports TG lazy-loading of map templates using turf reservations. For now, this just adds one verb Map Template - Lazy Load which will load a template of your choice on a reserved z-level.

How does this system work?

  • Use SSmapping.lazy_load_template(template), where template is an instance of a map_template of your choice.
  • This will create a turf reservation for that space, and cordon it with black-opaque walls.
  • If there is no more space left, it will create a new z-level, and do the reservation there.
  • It will then load the map in that space, placing the cordon around the map.

This PR also removes the similar but unused heaped space z-levels.

Why It's Good For The Game

We can have BIGGER CENTRAL COMMAND. And most of all, less fucking shit on Z1. Eventually this system can be expanded to automate shuttle transit.

Images of changes

image
image
image

Testing

See above. A lot of testing.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
NPFC
/:cl:

@Contrabang Contrabang added the Administration This PR relates to ingame administration features label Jan 25, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Jan 25, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 26, 2025
@Contrabang Contrabang requested a review from lewcc February 6, 2025 18:03
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could go wrong

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 7, 2025
@Burzah Burzah added this pull request to the merge queue Feb 7, 2025
Merged via the queue into ParadiseSS13:master with commit f9f3b4a Feb 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Administration This PR relates to ingame administration features Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants