Fix RCD interactions with invalid types #28093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burzah
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Due to how RCDs try to interact with atoms by looping through their actions, they'd wind up showing the suicide message if trying to deconstruct something invalid.
This adds a proper check, and also tweaks what gets passed in certain proc calls to retain functionality.
Why It's Good For The Game
Fixes #25891
Images of changes
thanksforallthefish.mp4
Testing
Used the RCD on an indestructible wall, built and deconstructed things. Let the thing meet my maker.
Declaration
Changelog
🆑
fix: Fixed bogus message/interact when trying to do an invalid deconstruct with the RCD
/:cl: