Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted atmos performance improvements. #27966

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Improves performance for a bunch of atmos machinery.
Makes SSair not sleep anymore.
Cleans up the atmos init data that shouldn't have been left lying around using memory.

Why It's Good For The Game

Performance good

Testing

Server ran normally.
Vents, scrubbers, portable vents, portable scrubbers, and canisters all worked normally.
Pipenets shared air correctly.
Atmos alert computer registered alert changes properly.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 13, 2025
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 17, 2025
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Burzah Burzah added this pull request to the merge queue Jan 20, 2025
Merged via the queue into ParadiseSS13:master with commit fdbd2b2 Jan 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants