Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates door remotes to the new attack chain + fixes janikeyring #27925

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Jan 9, 2025

What Does This PR Do

Fixes #27816
Migrates door remotes to the new attack chain
Removes an unused var from airlocks and unused procs from door remotes

Why It's Good For The Game

new attack chain + bug bad

Testing

None of the remotes tapped objects pre-migration and none of them tap objects after.

Janitor Keyring

  • Activate self jiggles
  • Interrupting do_after stops it
  • Doesn't work from range
  • Opens doors with matching access
  • Doesn't open doors with wrong access

Door Remote

  • Activate self changes modes
  • Works from distance
  • Works up close
  • Doesn't open doors with wrong access
  • Opens/Bolts/EA's/Speeds doors

Access Tuner

  • Activate self changes modes
  • Works from distance
  • Works up close
  • Interrupting do_after stops it
  • Opens/Bolts/EA's/Speeds doors

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@Toastical Toastical changed the title Migrates door remotes to the new attack chain Migrates door remotes to the new attack chain + fixes janikeyring Jan 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting review This PR is awaiting review from the review team label Jan 11, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 18, 2025
@Burzah Burzah added Attack Chain Migration Refactoring of legacy attack chain items Fix This PR will fix an issue in the game labels Jan 21, 2025
@Burzah Burzah added this pull request to the merge queue Jan 21, 2025
Merged via the queue into ParadiseSS13:master with commit fda350c Jan 21, 2025
17 checks passed
@Toastical Toastical deleted the door-remotes branch January 22, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Attack Chain Migration Refactoring of legacy attack chain items Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Janitor's key not working
4 participants