Fix camera console feeds not following moving cameras #27851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactor the screen-setting logic in camera consoles to its own method, and additionally calls that method whenever a video camera is moved, if that video camera's feed is being watched by a camera console.
Extracts camera follow lag into a variable on video cameras called `update_viewer_cooldown_rate` and reduces it from 3 to 2 seconds. Additionally, adds another variable on video cameras called `update_viewer_stabilization_rate`, which updates all tuned-in camera consoles with the new position of the video camera a final time, so the feed remains centered on the camera.
DGamerL
previously requested changes
Jan 6, 2025
|
Does this also fix the ERTs camera monitor? |
lewcc
reviewed
Jan 6, 2025
Makes camera consoles refresh their feeds every 2 seconds as long as they have active watchers. This fixes camera bugs, ERT cameras, video cameras (including the journalist's advanced video camera), and any other mobile cameras on a console's camera network.
FunnyMan3595
requested changes
Jan 17, 2025
Co-authored-by: Charlie Nolan <funnyman3595@gmail.com>
FunnyMan3595
approved these changes
Jan 17, 2025
Burzah
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This change makes camera consoles refresh their feeds every 2 seconds as long as they have active watchers. This fixes unmoving feeds for camera bugs, ERT cameras, video cameras (including the journalist's advanced video camera), and other mobile cameras on a console's camera network.
Why It's Good For The Game
Having to manually refresh over and over in order to follow a moving camera is bad for ergonomics and immersion.
Testing
I logged in with two clients and observed as both. I dispatched an ERT and signed up for it on one of the clients, and chose to become the commander. I looked at the special ops console and watched as the camera feed moved with me.
I then had the other observer re-incarnate as a Captain, and spawned a camera bug syndicate kit. I placed a camera bug on the Captain, and gave the camera bug device to the ERT Commander, and had them watch Hidden Camera #1. I had the Captain move around CentComm, and the feed moved with the Captain. I had the Captain remove the bug and throw it, and the feed moved with the bug.
I teleported both the Captain and ERT observer to the bar. I spawned a video camera and gave it to the Captain. I had the Captain enable it, and had the ERT commander watch the Captain on the bar entertainment console. I had the Captain move around the station, and saw the bar feed the ERT was watching move with the captain.
I did this again with an advanced video camera, to the same effect.
Declaration
Changelog
🆑 Ascio
fix: Fixed camera consoles not following moving cameras (e.g. video cameras, ERT cams, camera bugs)
/:cl: