Cyborg Inventory Refactor #27788
Merged
Cyborg Inventory Refactor #27788
+254
−312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewcc
reviewed
Jan 8, 2025
Dr and Lewc reviews Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Co-authored-by: Drsmail <60036448+Drsmail@users.noreply.github.com> Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
lewcc
reviewed
Jan 30, 2025
Burzah
reviewed
Feb 2, 2025
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com> Signed-off-by: BiancaWilkson <42818125+BiancaWilkson@users.noreply.github.com>
Burzah
approved these changes
Feb 7, 2025
lewcc
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR refactors most of how the three main cyborg inventory slots are handled. Previously, the screens and the 3 modules were each hardcoded in seperately. This changes them to use a list. There's also now support for items that need a signal for when they are activated or unactivated, like ore bags needing a target to listen to. Fixes #27733
Why It's Good For The Game
Bugs are bad, decade old code being rewritten is good.
Testing
Spawned in as a cyborg:
Selected each of my inventory slots
Cycled through each of my inventory slots
Put items into each of my inventory slots
Replaced glass floors with metal
Tried picking up ore automatically as a cyborg and as a human
Declaration
Changelog
🆑
fix: Cyborg ore bags work properly now
tweak: Swapping, cycling, and selecting modules functions slightly different than before, it'll take some muscle memory adjusting.
/:cl: