Ports Anti-magic from TG. #27560
Merged
Ports Anti-magic from TG. #27560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heretic? |
upcoming project for a heretic port |
|
!wiki_label |
DGamerL
approved these changes
Jan 1, 2025
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com> Signed-off-by: Qwertytoforty <52090703+Qwertytoforty@users.noreply.github.com>
Burzah
approved these changes
Jan 2, 2025
Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Burzah <116982774+Burzah@users.noreply.github.com>
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
What Does This PR Do
Adds antimagic.
This wonderful trait allows a user to be resistant to mind magic, unholy magic, or magic:tm: magic.
For example, nullrods will make a person immune to cult or vampire spells, but a fireball to a face will still hurt.
The immortality talisman miners and wizards get provides antimagic and allows casting with antimagic.
The beserker armor provides antimagic, but does not allow casting of magic.
The ERT gamma inquisitor armor provides antimagic but does not allow the casting of magic.
The wizard hardsuit provides antimagic and allows casting with antimagic.
Some spells can be cast with antimagic, things like bless, or the bynat.
adds COMSIG_ATOM_HOLY_ATTACK, needed for heretic
Why It's Good For The Game
Needed for heretic.
Makes handling of cult / vampires better.
Allows for wizards to get a potential weakness, though it doesnt protect the user from getting guns summoned on their ass, or just a normal gun a wizard uses.
As for heretic, allows one to potentially equip ERT (as an admin) or security (as a player with chaplain or minings help) to better deal with them.
Testing
cast so many spells. Note, some will have been missed, or may not be antimagic flagged properly. I went through each one, but there are a lot of spells in the code.
Cult handed and magic handed people with antimagic
Shot them with magic projectiles
Tried to cast spells with antimagic
Declaration
Changelog
🆑
add: Adds antimagic. Nullrods better protect from cult and vampire spells / abilities, but not fireballs or wizard magic.
add: Adds full antimagic to the wizard hardsuit, gamma inquisitor ERT armor, immortality talisman, berserker armor. Some of these will disrupt your magic casting.
/:cl: