Attack Chain Migration: traitordevices.dm to activate_self #27529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burzah
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
converts traitordevices.dm to activate_self
Why It's Good For The Game
We should be killing off legacy stuff, and this is simple practice for me.
Testing
Used Radio jammer in hand. Saw chat messages, tried to use radio, jammed, turned it off.
Teleported self with syndicate teleporter.
Tried to use fireproofing injector as a human, failed. Injected self as plasmaman. Tried to inject self again, failed.
Tried using cryoregenerative injector as a plasmaman, failed. Injected self as a drask, worked. Attempted again, failed.
Used mindbatterer, worked. Threw it, still worked.
Used the handheld mirror, worked.
Confirmed all converted items had new_attack_chain = TRUE
Declaration
Changelog
NPFC