Fix DmIcon BSOD #27187
Merged
Fix DmIcon BSOD #27187
+48
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
approved these changes
Oct 25, 2024
Burzah
approved these changes
Nov 8, 2024
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #27186
Added protection against BSOD, now if someone is very unlucky and for some reason something doesn't work in DmIcon, he will at least be able to use interfaces where it is used, although without pictures.
Rough, but I have no idea why in very rare cases in some people (I counted 3 in all time), DmIcon causes BSOD
Why It's Good For The Game
You can buy some cola even if DmIcon crushes on you
Testing
Renamed icon_ref_map,json to wrong name, which cause BSOD without "fix"
Declaration
Changelog
🆑
fix: Vendors should no longer cause a BSOD if there is some error with image loading
/:cl: